drivers: serial: uart_mspm0: clk from dts and tx irq correction #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For CI tests to pass, we point to our changes for MSPM0 in hal_ti Signed-off-by: Jackson Farley <[email protected]>
added necessary soc files for TI MSPM0 family Signed-off-by: Jackson Farley <[email protected]>
added TI MSPM0 device support to the devicetree Signed-off-by: Jackson Farley <[email protected]>
added pinctrl driver support for MSPM0 Family Signed-off-by: Jackson Farley <[email protected]>
Added GPIO driver support for TI MSPM0 family Signed-off-by: Jackson Farley <[email protected]>
added the Serial (uart) driver for MSPM0 family Signed-off-by: Jackson Farley <[email protected]>
Added TI LP_MSPM0G3507 board for MSPM0 Family Signed-off-by: Jackson Farley <[email protected]>
The logic seems to be inverted. Signed-off-by: Hans Binderup <[email protected]>
The clock frequency was previously hardcoded. Instead use the clock frequency provided by the dts config. Signed-off-by: Hans Binderup <[email protected]>
msp-ti
force-pushed
the
mspm0_upstream
branch
2 times, most recently
from
a626b1d to
979c943
Compare
|
Right but no longer necessary. Additional edits were made within the uart driver that render these not necessary |
msp-ti
force-pushed
the
mspm0_upstream
branch
8 times, most recently
from
fef4852 to
7c960e4
Compare
msp-ti
force-pushed
the
mspm0_upstream
branch
3 times, most recently
from
cd8d132 to
6ac0eae
Compare
msp-ti
pushed a commit
that referenced
this pull request
Nov 2, 2024
hci_packet_complete(buf, buf_size) should check whether buf_size is
enough.
For instance, hci_packet_complete can receive buf with buf_size 1,
leading to the buffer overflow in cmd->param_len, which is buf[3].
This can happen when rx_thread() receives two frames in 512 bytes
and the first frame size is 511. Then, rx_thread() will call
hci_packet_complete() with 1.
==5==ERROR: AddressSanitizer: global-buffer-overflow on address
0x000000ad81c2 at pc 0x0000005279b3 bp 0x7fffe74f5b70 sp 0x7fffe74f5b68
READ of size 2 at 0x000000ad81c2 thread T6
#0 0x5279b2 (/root/zephyr.exe+0x5279b2)
#1 0x4d697d (/root/zephyr.exe+0x4d697d)
#2 0x7ffff60e5daa (/lib/x86_64-linux-gnu/libc.so.6+0x89daa)
(BuildId: 2e01923fea4ad9f7fa50fe24e0f3385a45a6cd1c)
0x000000ad81c2 is located 2 bytes to the right of global variable
'rx_thread.frame' defined in 'zephyr/drivers/bluetooth/hci/userchan.c'
(0xad7fc0) of size 512
SUMMARY: AddressSanitizer: global-buffer-overflow
(/root/zephyr.exe+0x5279b2)
Thread T6 created by T2 here:
#0 0x48c17c (/root/zephyr.exe+0x48c17c)
#1 0x530192 (/root/zephyr.exe+0x530192)
#2 0x4dcc22 (/root/zephyr.exe+0x4dcc22)
Thread T2 created by T1 here:
#0 0x48c17c (/root/zephyr.exe+0x48c17c)
#1 0x530192 (/root/zephyr.exe+0x530192)
#2 0x4dcc22 (/root/zephyr.exe+0x4dcc22)
Thread T1 created by T0 here:
#0 0x48c17c (/root/zephyr.exe+0x48c17c)
#1 0x52f36c (/root/zephyr.exe+0x52f36c)
#2 0x5371dc (/root/zephyr.exe+0x5371dc)
#3 0x5312a6 (/root/zephyr.exe+0x5312a6)
#4 0x52ed7b (/root/zephyr.exe+0x52ed7b)
#5 0x52eddd (/root/zephyr.exe+0x52eddd)
#6 0x7ffff6083c89 (/lib/x86_64-linux-gnu/libc.so.6+0x27c89)
(BuildId: 2e01923fea4ad9f7fa50fe24e0f3385a45a6cd1c)
==5==ABORTING
Signed-off-by: Sungwoo Kim <[email protected]>
msp-ti
force-pushed
the
mspm0_upstream
branch
3 times, most recently
from
374b0bb to
f3123b1
Compare
msp-ti
force-pushed
the
mspm0_upstream
branch
3 times, most recently
from
87e5b26 to
c235b9f
Compare
msp-ti
force-pushed
the
mspm0_upstream
branch
6 times, most recently
from
861c5da to
d4b42c4
Compare
JFMSP
force-pushed
the
mspm0_upstream
branch
2 times, most recently
from
8d72876 to
d0c9952
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see each commit for details.
NOTE: the changes are based on the earlier driver before some of the changes from AudioStreamingPlatform/zephyr@58c86d1...AudioStreamingPlatform:zephyr:2f522943f5f771475cf1f71f68d8f132ea523abb was merged. But it seems that some of the changes are missing hence this PR.